-
Notifications
You must be signed in to change notification settings - Fork 30
chore(public/sendme.sh
): POSIX compliance and verbosity
#318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Make `if`-conditional POSIX compliant to allow for `/bin/sh` that is not Bash * Wrap cmdline params to prevent globbing and word splitting * Add verbosity to `tar` to allow user to see where the binary is unpacked to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should sed -E
be used instead of sed -r
for POSIX portability, as mentioned in the sed
docs?
-E, -r, --regexp-extended
use extended regular expressions in the script
(for portability use POSIX -E).
On FreeBSD, where -r Same as -E for compatibility with GNU sed. So it should be fine I guess. UPD: let me know and I can update |
Okay, then there shouldn't be any issues. The current changes are good. |
@neuralpain Can you please dismiss your changes request? |
if
-conditional POSIX compliant to allow for/bin/sh
that is not Bashtar
to allow user to see where the binary is unpacked to