-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
WGSLNodeBuilder: Improve isCustomStruct()
checking
#30525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
@sunag Is there a way to update parts of a storageBufferAttribute from the CPU side?
I also had an example with interleaved buffers in mind but that would be a bit more extensive. |
d48652d
to
3376eb8
Compare
@sunag I've removed the example because I can't get the screenshot to work. I have no idea why it keeps going black. It works perfectly when I run the example itself. I also get a black screen with other examples. I'll probably need this also for my voxelizer in the future. I created it to simulate real buoyancy. With the voxelizer I can calculate the volume of misshapen bodies very well. https://github.com/Spiri0/Threejs-WebGPU-Voxelizer I also switched the IFFT ocean to buffers. It works much better that way. |
@Spiri0 I'll check this PR this weekend. Thanks! |
@sunag The extension in |
@Spiri0 Can you confirm if with this change works for you? |
Yes, that looks good, it's working. I see you solved it elsewhere in the code, interesting. |
Yes, it should be useful for other functions like |
isCustomStruct()
checking
#30394 #30487
I recreated the PR because I had big problems with creating the screenshot and the branch was completely destroyed as a result. I was only able to create the screenshot with changes in puppeteer.js and the screenshot still doesn't fit.
The code itself works perfectly. @sunag you have a new node in mind for the structArray anyway. That's why I'm holding off on experimenting with screenshots for the moment