Skip to content

avoid collision on aliases in MilvusClient _create_connection #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

avoid collision on aliases in MilvusClient _create_connection #2716

wants to merge 2 commits into from

Conversation

jperez999
Copy link

This PR handles the #2715

It ensures that only one alias is used when calling connections.connect within the milvus client. This will allow users to create milvus connections to multiple milvus instances in the same context without worrying about collisions on aliases.

@sre-ci-robot
Copy link

Welcome @jperez999! It looks like this is your first PR to milvus-io/pymilvus 🎉

@jperez999 jperez999 changed the title avoid collision on aliases in _create_connection avoid collision on aliases in MilvusClient _create_connection Mar 31, 2025
@mergify mergify bot added the needs-dco label Mar 31, 2025
@jperez999 jperez999 mentioned this pull request Apr 17, 2025
Open
1 task
@nwstephens
Copy link

@liliu-z and @alexanderguzhva can we get eyes on this please? It's important to the work we're doing.

@nwstephens
Copy link

@liliu-z says "looks good to me"

@nwstephens
Copy link

/assign @longjiquan

@liliu-z
Copy link
Member

liliu-z commented Apr 23, 2025 •
edited
Loading

/assign @XuanYang-cn
Plz take a look

@XuanYang-cn
Copy link
Contributor

@jperez999 Please sign off this PR to pass the DCO check. ref:https://github.com/milvus-io/pymilvus/pull/2716/checks?check_run_id=39724390359

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jperez999
To complete the pull request process, please ask for approval from longjiquan after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zhengbuqian and others added 2 commits April 23, 2025 11:17
@zhengbuqian @jperez999
weighted reranker to allow skip score normalization (milvus-io#2708)
b440efe 
issue: milvus-io/milvus#40836

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
Signed-off-by: Julio Perez <jperez@nvidia.com>
@jperez999
avoid collision on aliases in _create_connection
57d6a72 
Signed-off-by: Julio Perez <jperez@nvidia.com>
@mergify mergify bot added dco-passed and removed needs-dco labels Apr 23, 2025
@jperez999
Copy link
Author

@XuanYang-cn I have made the changes and the PR is now passing DCO

@XuanYang-cn
Copy link
Contributor

@jperez999 THX for sign off this PR. Please fix the code checker with the following codes.

pip install -e ".[dev]"
make format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@longjiquan longjiquan Awaiting requested review from longjiquan

At least 1 approving review is required to merge this pull request.

Assignees

@longjiquan longjiquan

@XuanYang-cn XuanYang-cn

Labels
dco-passed size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jperez999 @sre-ci-robot @nwstephens @liliu-z @XuanYang-cn @longjiquan @zhengbuqian