fix nullability of AssemblyEnumerator.GetTypes #5401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReflectionTypeLoadException.Types
returnsType?[]
https://learn.microsoft.com/en-us/dotnet/api/System.Reflection.ReflectionTypeLoadException.Types?view=net-9.0 to return type ofAssemblyEnumerator.GetTypes
is incorrectReflectionTypeLoadException.LoaderExceptions
returns aException?[]
https://learn.microsoft.com/en-us/dotnet/api/system.reflection.reflectiontypeloadexception.loaderexceptions?view=net-9.0 so the null check is a no-op. i assume the intent is to "log a warning and continue with loaded types if there are LoaderExceptions"GetAssemblyInfo
would redundantly attempt toIsDerivedAttributeDefined
for a null value, and then catch the result null ref excpetion