-
Notifications
You must be signed in to change notification settings - Fork 3.8k
.Net: Introduce Gemini Thinking Budget Configuration. #11647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shethaadit
wants to merge
19
commits into
microsoft:main
Choose a base branch
from
shethaadit:shethaadit/FixBug11645
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @RogerBarreto / @markwallace-microsoft, appreciate your help in reviewing this PR. |
dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Google/GeminiThinkingConfig .cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Google/GeminiThinkingConfig .cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Google.UnitTests/Core/Gemini/GeminiRequestTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…ettings.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…ettings.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
RogerBarreto
approved these changes
Apr 24, 2025
dmytrostruk
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Title:
feat(connectors-google): Introduce Gemini Thinking Budget Configuration
Closes 11645
Description:
This pull request introduces the
GeminiThinkingConfig
class and theThinkingConfig
property withinGeminiPromptExecutionSettings
to support the thinking budget feature available in Gemini 2.5 and similar experimental models.Key changes include:
GeminiThinkingConfig
class with aThinkingBudget
property for controlling the number of thinking tokens.ThinkingBudget
property withinGeminiThinkingConfig
, ensuring it adheres to the API requirements (range 0-24576, with 1-1023 clamped to 1024).ThinkingConfig
property toGeminiPromptExecutionSettings
, allowing users to configure the thinking budget for Gemini 2.5 models.ThinkingConfig
property setter to ensure it's only used with Gemini 2.5 model IDs, throwing anInvalidOperationException
otherwise.ThinkingConfig
andThinkingBudget
, covering valid and invalid input scenarios, as well as the model ID restriction.This enhancement enables developers to leverage the thinking budget feature for more complex tasks with supported Gemini models.
Contribution Checklist
Fixes #11645