-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement accessibilityLevel for Fabric #14593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement accessibilityLevel for Fabric #14593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds support for the new accessibilityLevel prop for Fabric, enabling enhanced UI automation properties for accessibility.
- Added the new accessibilityLevel property to view props.
- Updated construction, property setting, and UI automation providers to handle the new level.
- Modified the RNTesterApp to include and display the new accessibilityLevel.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
HostPlatformViewProps.h | Added the accessibilityLevel property to the view props. |
HostPlatformViewProps.cpp | Initialized and set the accessibilityLevel property during props construction and via the prop setter. |
CompositionViewComponentView.cpp | Updated UI Automation properties to include the new accessibilityLevel. |
CompositionDynamicAutomationProvider.cpp | Extended the property provider to return the accessibilityLevel value for UI automation. |
RNTesterApp-Fabric.cpp | Extended the test app to retrieve and verify the accessibilityLevel property. |
Files not reviewed (1)
- change/react-native-windows-5aa167ea-3ec8-4b11-87ed-14f728f2eec6.json: Language not supported
Please update the "What", "Testing", and "Changelog" sections of the PR to include relevant information, once you're ready for the PR to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome these changes are looking good. once you add a test case, I'll re-review for approval.
...eact-native-windows/tester/src/js/examples-win/Accessibility/AccessibilityExampleWindows.tsx
Outdated
Show resolved
Hide resolved
56739f6
to
9f34321
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This looks good to go 👍
Description
see #14550 for the behavior of this prop.
Type of Change
Why
Add Support for accessibilityLevel Prop
Resolves [#14550 , #14551]
What
accessibilityLevel/ aria-level
as UIA propertylevel
accessibilityLevel/ aria-level
valueScreenshots
The below screenshots will show to difference using the Accessibility Insights for Windows tool
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Tested using Playground and RNTester fabric App . Also added test cases to ensure the changes will work.
Changelog
Should this change be included in the release notes: yes
Add Support for
accessibilityLevel
PropMicrosoft Reviewers: Open in CodeFlow