Skip to content

Fixing implicit instantiation errors with newer libc++ on macOS #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixing implicit instantiation errors with newer libc++ on macOS #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Release/include/cpprest/streams.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,20 @@ template<>
struct Value2StringFormatter<uint8_t>
{
template<typename T>
static std::basic_string<uint8_t> format(const T& val)
static std::vector<uint8_t> format(const T& val)
{
std::basic_ostringstream<char> ss;
std::ostringstream ss;
ss << val;
return reinterpret_cast<const uint8_t*>(ss.str().c_str());
std::string s = ss.str();

return std::vector<uint8_t>(reinterpret_cast<const uint8_t*>(s.data()),
reinterpret_cast<const uint8_t*>(s.data()) + s.size());
}

static std::basic_string<uint8_t> format(const utf16string& val)
static std::vector<uint8_t> format(const utf16string& val)
{
return format(utility::conversions::utf16_to_utf8(val));
std::string utf8 = utility::conversions::utf16_to_utf8(val);
return format(utf8);
}
};

Expand Down