-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Add ability to register Agent instances #6131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6131 +/- ##
==========================================
+ Coverage 77.08% 77.32% +0.23%
==========================================
Files 197 197
Lines 13637 13863 +226
==========================================
+ Hits 10512 10719 +207
- Misses 3125 3144 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a few tests for the case of successful registration of instances and then
- send_message to the registered agent, successfully respond with a reply.
- publish_message to a topic subscribed by the agent, successfully observed a state change in the agent itself.
…ogen into register_agent_instances
@@ -17,6 +17,10 @@ def id(self) -> AgentId: | |||
"""ID of the agent.""" | |||
... | |||
|
|||
async def init(self, **kwargs: Any) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async def init(self, **kwargs: Any) -> None: | |
async def bind_id_and_runtime(self, id: AgentId, runtime: AgentRuntime) -> None: |
I think we shoud make this a concrete call otherwise it is unclear how or why it would be used
Why are these changes needed?
Nice to have functionality
Related issue number
Closes #6060
Checks