Copy RouteOptions as its most specific type #3192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where copying a RouteOptions subclass resulted in an instance of RouteOptions itself.
1ec5
force-pushed
the
1ec5-options-copy-type-3191
branch
from
37d7960 to
e47a51c
Compare
MaximAlien
approved these changes
Jul 21, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where copying an instance of a RouteOptions subclass resulted in an instance of RouteOptions itself. Now calling
RouteOptions.copy()always returns the same specific type as the original object.Along for the ride,
RouteOptions.without(waypoint:)has been renamedRouteOptions.without(_:), because the argument label is redundant to the argument type at the point of use.Fixes #3191.
/cc @mapbox/navigation-ios @OttyLab