Minimize NSObject inheritance #2352
Conversation
…ogress, RouteStepProgress, DataCache, FeedbackItem, NavigationOptions, StyleManager
…tings update notifications
…ndler callback to respond to legIndex updates
Udumft
added
op-ex
| @@ -34,15 +34,16 @@ open class RouteController: NSObject { | |||
| } | |||
|
|
|||
| private var _routeProgress: RouteProgress { | |||
| willSet { | |||
| resetObservation(for: _routeProgress) | |||
| } | |||
| didSet { | |||
| movementsAwayFromRoute = 0 | |||
| updateNavigator(with: _routeProgress) | |||
| updateObservation(for: _routeProgress) | |||
There was a problem hiding this comment.
Shouldn't we not only subscribe to legIndex updates here, but also run the subscription handler too to update RouteController with new _routeProgress?
There was a problem hiding this comment.
I'm not sure what you mean by this? _routeProgress is the memoized property that represent's RouteController's copy of the current route progress.
There was a problem hiding this comment.
When _routeProgress is set, we observe it's legIndex to call updateRouteLeg when it is updated. But shouldn't we call updateRouteLeg right now, since we've just updated the entire _routeProgress and thus it's legIndex is technically updated too.
There was a problem hiding this comment.
@Udumft No, it's unnecessary, because the leg is set when we call updateNavigator(with:).
| @@ -34,15 +34,16 @@ open class RouteController: NSObject { | |||
| } | |||
|
|
|||
| private var _routeProgress: RouteProgress { | |||
| willSet { | |||
| resetObservation(for: _routeProgress) | |||
| } | |||
| didSet { | |||
| movementsAwayFromRoute = 0 | |||
| updateNavigator(with: _routeProgress) | |||
| updateObservation(for: _routeProgress) | |||
There was a problem hiding this comment.
I'm not sure what you mean by this? _routeProgress is the memoized property that represent's RouteController's copy of the current route progress.
Resolves #2294
Removes some objects NSObject Inheritance. Existing KVO observers are removed in favor of using NSNotifications observations.
There are also some other Public available classes, inheriting NSObject:
Didn't check in detail, if such inheritance is legitimate, but quick removing NSObject from declaration showed successful compile. Should I check these too?