Skip to content

refactor(job): show job request attrs on print #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Apr 23, 2025

this is technically not a bug, just a weird thing that JavaScript does, where getters aren't shown on console.log(), so it looks like the object is empty. this PR just sets them statically as readonly.

closes #346

this is technically not a bug, just a weird thing that JavaScript does,
where getters aren't shown on `console.log()`, so it looks like the
object is empty. this PR just sets them statically as readonly.
@nbsp nbsp requested a review from Shubhrakanti April 23, 2025 16:34
Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: 8161ecc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@livekit/agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Shubhrakanti Shubhrakanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clutch. Can you add to the PR description what printing the job should look like?

Also let's make sure we let the person that filed this know it's been updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants