Add Clear VPI #827
Draft
Add Clear VPI #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VPI class add constants
Tymotey
force-pushed
the
Purge-Add_VPI_clenaup
branch
from
90ab288 to
29af4c7
Compare
|
@timotei-litespeed Is there any request for this feature? |
hi-hai
reviewed
Apr 19, 2025
src/media.cls.php
Outdated
| @@ -646,7 +646,7 @@ private function _parse_img_for_preload() | |||
| { | |||
| // Load VPI setting | |||
| $is_mobile = $this->_separate_mobile(); | |||
| $vpi_files = $this->cls('Metabox')->setting($is_mobile ? 'litespeed_vpi_list_mobile' : 'litespeed_vpi_list'); | |||
| $vpi_files = $this->cls('Metabox')->setting($is_mobile ? $this->cls('Vpi')::POST_META_MOBILE : $this->cls('Vpi')::POST_META); | |||
There was a problem hiding this comment.
This is a weird const usage approach. Please don't use this way anymore
There was a problem hiding this comment.
Another way: constant($className . '::' . $constantName)
There was a problem hiding this comment.
@hi-hai I think is better
hi-hai
reviewed
Apr 19, 2025
tpl/toolbox/purge.tpl.php
Outdated
| @@ -93,6 +93,15 @@ | |||
| ); | |||
| } | |||
|
|
|||
| if ($this->has_cache_folder('vpi')) { | |||
| $_panels[] = array( | |||
| 'title' => __('Purge All', 'litespeed-cache') . ' - ' . __('VPI', 'litespeed-cache'), | |||
There was a problem hiding this comment.
VPI shouldn't be translated @timotei-litespeed
There was a problem hiding this comment.
Removed translation
hi-hai
reviewed
Apr 19, 2025
src/gui.cls.php
Outdated
| $wp_admin_bar->add_menu(array( | ||
| 'parent' => 'litespeed-menu', | ||
| 'id' => 'litespeed-purge-placeholder', | ||
| 'title' => __('Purge All', 'litespeed-cache') . ' - ' . __('VPI data', 'litespeed-cache'), |
There was a problem hiding this comment.
Why is this menu different than the FE one?
There was a problem hiding this comment.
By mistake, fixed
We had a few request past few months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Purge VPI data
Move VPI meta fields names to constants in VPI class