text-splitters: Set strict mypy rules #30900
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cbornet
commented
Apr 17, 2025
cbornet
commented
- Add strict mypy rules
- Fix mypy violations
- Add error codes to all type ignores
- Add ruff rule PGH003
- Bump mypy version to 1.15
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
sydney-runkle
approved these changes
Apr 17, 2025
| @@ -70,7 +74,7 @@ ignore_missing_imports = "True" | |||
| target-version = "py39" | |||
|
|
|||
| [tool.ruff.lint] | |||
| select = ["E", "F", "I", "T201", "D"] | |||
| select = ["E", "F", "I", "PGH003", "T201", "D"] | |||
There was a problem hiding this comment.
Can we add UP (pyupgrade)? Reminded of this bc of the List -> list changes.
There was a problem hiding this comment.
Can be done in a different PR
There was a problem hiding this comment.
Yes, can be done in another PR
| token_ids_with_start_and_end_token_ids = self.tokenizer.encode( | ||
| text, | ||
| max_length=self._max_length_equal_32_bit_integer, | ||
| truncation="do_not_truncate", | ||
| ) | ||
| return token_ids_with_start_and_end_token_ids | ||
| return cast("list[int]", token_ids_with_start_and_end_token_ids) |
There was a problem hiding this comment.
Surprised we have to cast this
There was a problem hiding this comment.
It's because mypy can't figure the type so it uses Any which is incompatible with the method signature.
dosubot
bot
added
the
lgtm
|
Happy to merge once CI is happy |
cbornet
force-pushed
the
text-splitters-mypy
branch
2 times, most recently
from
4a5e08f to
7f762cf
Compare
cbornet
force-pushed
the
text-splitters-mypy
branch
from
7f762cf to
748e778
Compare
It now is 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.