core: Cleanup Pydantic models and handle deprecation warnings #30799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cbornet
commented
Apr 12, 2025
•
cbornet
commented
- Simplified Pydantic handling since Pydantic v1 is not supported anymore.
- Replace use of deprecated v1 methods by corresponding v2 methods.
- Remove use of other deprecated methods.
- Activate mypy errors on deprecated methods use.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
cbornet
force-pushed
the
pydantic-cleanup
branch
3 times, most recently
from
7529366 to
5fcb2bb
Compare
cbornet
force-pushed
the
pydantic-cleanup
branch
3 times, most recently
from
14905a4 to
6b9bb2c
Compare
cbornet
commented
Apr 13, 2025
| @@ -183,6 +122,9 @@ def pre_init(func: Callable) -> Any: | |||
| with warnings.catch_warnings(): | |||
| warnings.filterwarnings(action="ignore", category=PydanticDeprecationWarning) | |||
|
|
|||
| # Ideally we would use @model_validator(mode="before") but this would change the | |||
| # order of the validators. See https://github.com/pydantic/pydantic/discussions/7434. | |||
| # So we keep root_validator for backward compatibility. | |||
There was a problem hiding this comment.
One possibility would be to deprecate pre_init and create a new decorator, for instance before_init, that uses model_validator.
WDYT ?
cbornet
force-pushed
the
pydantic-cleanup
branch
from
6b9bb2c to
d4b2366
Compare
dosubot
bot
added
size:XL
|
I would love to drop v1 support (would clean up the codebase a lot). Need to chat with the team about this depending on download #s, etc. |
|
Note: LangChain already dropped support for Pydantic v1. There remains some models using |
cbornet
force-pushed
the
pydantic-cleanup
branch
from
d4b2366 to
3c2f2ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.