feat: add a toggle for automatic rank/world_size discovery #3633
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-ju
changed the title
python/python/lance/torch/data.py
Outdated
Comment on lines
296
to
297
| rank = get_global_rank() | ||
| world_size = get_global_world_size() |
There was a problem hiding this comment.
could we just take rank and world_size in the args? if both are None, use inference, if they are set then use the provided values
There was a problem hiding this comment.
Or, use a NO_AUTO_INIT = -1 value to avoid this branch?
Signed-off-by: jukejian <jukejian@bytedance.com>
|
@chebbyChefNEQ I made some updates. Do you have time to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am implementing a scheme to turn some tasks of building indexes on the current GPU into a single-machine multi-GPU scheme. However, I found that the current TorchDataset cannot be switched between single-machine single-GPU and single-machine multi-GPU. T
herefore, a switch is added here.