feat(v2): example generic task processor #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2025
damiramirez
commented
Apr 29, 2025
Comment on lines
+43
to
+91
| let contract_task = ContractTask { | ||
| numberToBeSquared: task.input, | ||
| taskCreatedBlock: task.task_created_block, | ||
| quorumNumbers: task.quorum_numbers, | ||
| quorumThresholdPercentage: task.quorum_threshold_percentage, | ||
| }; | ||
|
|
||
| let contract_response = ContractTaskResponse { | ||
| numberSquared: response.response, | ||
| referenceTaskIndex: response.task_index, | ||
| }; | ||
|
|
||
| let apk_g2 = G2Point { | ||
| X: non_signer_stakes_and_signature.apkG2.X, | ||
| Y: non_signer_stakes_and_signature.apkG2.Y, | ||
| }; | ||
|
|
||
| let sigma = G1Point { | ||
| X: non_signer_stakes_and_signature.sigma.X, | ||
| Y: non_signer_stakes_and_signature.sigma.Y, | ||
| }; | ||
|
|
||
| let quorum_apks = non_signer_stakes_and_signature | ||
| .quorumApks | ||
| .iter() | ||
| .map(|apk| G1Point { X: apk.X, Y: apk.Y }) | ||
| .collect(); | ||
|
|
||
| let non_signer_pubkeys = non_signer_stakes_and_signature | ||
| .nonSignerPubkeys | ||
| .iter() | ||
| .map(|pubkey| G1Point { | ||
| X: pubkey.X, | ||
| Y: pubkey.Y, | ||
| }) | ||
| .collect(); | ||
|
|
||
| let non_signer_stakes_and_signature = ContractNonSignerStakesAndSignature { | ||
| nonSignerStakeIndices: non_signer_stakes_and_signature.nonSignerStakeIndices, | ||
| nonSignerQuorumBitmapIndices: non_signer_stakes_and_signature | ||
| .nonSignerQuorumBitmapIndices, | ||
| quorumApkIndices: non_signer_stakes_and_signature.quorumApkIndices, | ||
| totalStakeIndices: non_signer_stakes_and_signature.totalStakeIndices, | ||
| apkG2: apk_g2, | ||
| quorumApks: quorum_apks, | ||
| nonSignerPubkeys: non_signer_pubkeys, | ||
| sigma, | ||
| }; | ||
|
|
There was a problem hiding this comment.
We have to find a way to avoid this
There was a problem hiding this comment.
Due to the simplicity, we could expose this functionality as a declarative macro.
maximopalopoli
approved these changes
Apr 29, 2025
damiramirez
merged commit f29d375
into
feat/generic-task-processor
8 of 11 checks passed
pablodeymo
added a commit
to Layr-Labs/eigensdk-rs
that referenced
this pull request
Apr 30, 2025
### What Changed? Rewrite aggregator logic. - Added a generic `TaskProcessor` trait to encapsulate custom task handling logic. - Added a contract wrapper interface `TaskManagerContract` to simplify integration with the user’s binding. - Made both `Task` and `TaskResponse` generic - Provided an `IndexingTaskProcessor` struct that implements `TaskProcessor` out of the box. Note: This PR currently breaks the example, it no longer compiles due to changes in the aggregator logic. We should merge the [example PR](lambdaclass#10) here. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Pablo Deymonnaz <deymonnaz@gmail.com> Co-authored-by: Pablo Deymonnaz <pdeymon@fi.uba.ar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of the aggreagtor using the new task processor