test(storybook): ActionIcon click DEV-98 #5669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # jsapp/js/components/common/actionIcon.stories.tsx
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
jsapp/js/components/common/actionIcon.stories.tsx:97
- [nitpick] For a more robust test, consider asserting the exact number of times the onClick handler is expected to be called (e.g., using toHaveBeenCalledTimes(1)) rather than simply checking if it was called.
await expect((args as StoryArgs).onClick).toHaveBeenCalled()
magicznyleszek
changed the title
magicznyleszek
changed the title
Akuukis
requested changes
Apr 14, 2025
Co-authored-by: Akuukis <Akuukis@users.noreply.github.com>
Co-authored-by: Akuukis <Akuukis@users.noreply.github.com>
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
jsapp/js/components/common/actionIcon.stories.tsx:90
- [nitpick] Consider using 'data-testid' instead of 'id' for test elements to align with the StoryArgs type and common testing conventions.
id: 'ActionIcon-click-test',
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
jsapp/js/components/common/actionIcon.stories.tsx:99
- [nitpick] Consider refining the Story type definitions to avoid the need for casting args. This can help maintain strong type safety throughout your tests.
await expect((args as StoryArgs).onClick).toHaveBeenCalledTimes(1)
jsapp/js/components/common/ActionIcon.tsx:22
- [nitpick] Setting displayName on the component before wrapping it with createPolymorphicComponent may not propagate as expected. Verify that the intended displayName appears correctly in React DevTools.
ActionIcon.displayName = 'ActionIcon'
Akuukis
approved these changes
Apr 14, 2025
| // TODO: I made an issue to point this out to Storybook team: https://github.com/storybookjs/storybook/issues/31106 | ||
| // let's fix this when they fix it. | ||
| const canvas = within(canvasElement) | ||
| await userEvent.click(canvas.getByTestId(testId)) |
There was a problem hiding this comment.
this looks more scalable to me in case of more than single test case.
Suggested change
| await userEvent.click(canvas.getByTestId(testId)) | |
| await userEvent.click(canvas.getByTestId((args as StoryArgs)['data-testid']!)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
<type>(<scope>)<!>: <title> TASK-1234frontendorbackendunless it's global💭 Notes
I was trying to come up with some "proper" way of having types in
args, but searching Storybook docs and thier GH gave me nothing useful. I made an issue to kindly point this out to Storybook team: storybookjs/storybook#31106.Other than that, it's just a simple test to show how it's done ;)
👀 Preview steps
Testing: