Add support for mypy==1.0.0, add docformatter #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2.
This is an ugly hack to walk around the issue thoroughly described here: python/mypy#14653 (comment) and here: mypyc/mypyc#973
Since we can't simply make the equality comparison of fullnames fail by overriding
__eq__, we're forcing them to be different by adding a bunch of invisible characters at the end 😬 But ultimately the aim of the plugin is to help humans, to whom the invisible characters are, well, invisible.I can see how it can hit performance (memory-wise), so if that starts to be a problem for somebody, we can try to throw more invisible characters into the pool and encode the
instance_counterwith more than one char. We're only using one on purpose now - for simplicity.The upper bound on the supported mypy versions is because of the new release versioning scheme announced. The plugin is prone to be affected even by minor backward incompatible changes.