Skip to content

feat: Use monaco editor instead of query builder for CEL #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

feat: Use monaco editor instead of query builder for CEL #4597

wants to merge 28 commits into from

Conversation

skynetigor
Copy link
Contributor

@skynetigor skynetigor commented Apr 20, 2025 •
edited
Loading

Closes #4598

📑 Description

  • Use Monaco editor for CEL query on alerts page to highlight syntax
  • Add field suggestions (kind of intellisense for CEL)
  • Cover new CEL editor with E2E for alerts
Screen.Recording.2025-04-20.at.18.06.12.mov

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

skynetigor added 14 commits April 15, 2025 17:07
@skynetigor
feat: add CEL input component with Monaco Editor support
e487fae
@skynetigor
feat: implement Monaco Editor with CEL language support
7b8cc9a
@skynetigor
feat: enhance Monaco Editor with transparent background and function …
c4b263d 
…syntax highlighting
@skynetigor
feat: add onMonacoLoaded callback to MonacoCelCDN for enhanced editor…
ae50a9a 
… integration
@skynetigor
refactor: replace MonacoCelCDN with MonacoCelEditor and clean up unus…
ccf76a4 
…ed files
@skynetigor
feat: update CelInput and MonacoCelEditor to support value binding an…
91db7f8 
…d change handling
@skynetigor
Merge branch 'main' into 4512-use-monaco-editor-instead-of-query-builder
8ee4569
@skynetigor
feat: enhance CelInput and MonacoCelEditor with additional event hand…
c52fd92 
…lers
@skynetigor
feat(cel-input): add placeholder support to enhance user experience
2f9e5e9
@skynetigor
feat: add fieldsForSuggestions to CelInput and MonacoCelEditor for en…
80bffb3 
…hanced autocomplete functionality
@skynetigor
feat(monaco-cel-editor): track suggestion visibility to not trigger k…
88f4463 
…eydown event when suggestion is chosen
@skynetigor
feat(monaco-cel-editor): enhance editor styling and overflow handling…
75565c4 
… for improved suggestion visibility
@skynetigor
feat(monaco-cel-editor): add MonacoCel component and update styling f…
83e9826 
…or improved layout
@skynetigor
refactor(monaco-cel-editor): remove unused MonacoCelCDN and MonacoCel…
2284302 
…NPM components
@vercel Vercel
Copy link

vercel bot commented Apr 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Apr 20, 2025 4:02pm

@skynetigor skynetigor marked this pull request as ready for review April 20, 2025 16:12
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Feature A new feature UI User interface related issues labels Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature A new feature size:XL This PR changes 500-999 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Use Monaco editor for CEL
1 participant
@skynetigor