fix: Replace some workflows exception logging with warning and include context #4590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text Updated the exception handling across various modules to use `logger.warning` instead of `logger.exception` or `logger.error`, providing better context with `exc_info` and additional metadata. This improves the clarity and debugging capabilities of the logged errors without being overly verbose.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:M
The exception variable `ex` was unused and has been removed to clean up the code. This change simplifies the exception handling while maintaining the current behavior.
|
@VladimirFilonov is there any example of the differences? as far as I know |
|
@shahargl yes, but with Error level, which creates a lot of noise in logs filtered by ERROR |
…es-a-lot-of-errors-in-logs-which-is-noisy
VladimirFilonov
deleted the
fix/4589-bug-misconfigured-workflows-generates-a-lot-of-errors-in-logs-which-is-noisy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the exception handling across various modules to use
logger.warninginstead oflogger.exceptionorlogger.error, providing better context withexc_infoand additional metadata. This improves the clarity and debugging capabilities of the logged errors without being overly verbose.Closes #4589
📑 Description
✅ Checks
ℹ Additional Information