Skip to content

fix: workflow execution trigger links #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tuantran0910
Copy link
Contributor

@tuantran0910 tuantran0910 commented Apr 16, 2025

Closes #4565

📑 Description

When viewing workflow executions, clicking on alerts/incidents in the Triggered by column sometimes redirects to incorrect links with undefined IDs, causing users to view unrelated items or broken links.

The reason is that the id of the alert may contains special characters like colons and plus signs. For example: dbt_docs_generate-generate_and_upload_metadata-scheduled__2025-04-16T14:30:00+00:00.

Before:

image

image

After:

image

image

Copy link

vercel bot commented Apr 16, 2025

@tuantran0910 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working UI User interface related issues labels Apr 16, 2025
@tuantran0910 tuantran0910 force-pushed the fix-workflow-execution-trigger-links branch from 9ebc977 to a70ce15 Compare April 17, 2025 12:36
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just use encodeURIComponent?

@tuantran0910
Copy link
Contributor Author

why not just use encodeURIComponent?

Will check it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Workflow execution table links for alerts and incidents not working
2 participants