-
Notifications
You must be signed in to change notification settings - Fork 943
feat: enhance provider and deduplication rule provisioning logic #4399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: enhance provider and deduplication rule provisioning logic #4399
Conversation
…and environment configuration
@tuantran0910 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
…es in provisioning
Hmm, storing the hash value when provisioning in local file storage might not be a good way when we have many backend replicas as mentioned in this issue #4398. Solved by use other |
…e instead of only local file
…isted_or_new_session
hey @tuantran0910 - although we want to get this functionality, we feel it's a bit over-engineering here. let's sync if see if there is simpler solution for that. |
Hi @shahargl, I completely agree with you. We always aim for the simplest solution to our problems. I don’t have much experience before, so I would really appreciate any advice you could share. Thanks! :D |
Signed-off-by: Tran Ngoc Tuan <94174684+tuantran0910@users.noreply.github.com>
…eduplication rules logging
…ging in ProvidersService
…ation rule handling
… handling and rollback mechanisms
Hi @talboren, @shahargl, I've simplified the provider management logic (as described in the issue/PR description). The process is now:
How do you guys think about this strategy ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4399 +/- ##
==========================================
- Coverage 46.77% 46.76% -0.01%
==========================================
Files 164 164
Lines 16841 16838 -3
==========================================
- Hits 7877 7874 -3
Misses 8964 8964 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #4401
📑 Description
When Keep starts or restarts, it follows these steps to manage provider configurations:
KEEP_PROVIDERS
environment variable or YAML files in theKEEP_PROVIDERS_DIRECTORY
.✅ Checks