-
Notifications
You must be signed in to change notification settings - Fork 531
feat: add message about mirror when nvd is down #5023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@terriko @mastersans PTAL and let me know if any changes are required.
|
Signed-off-by: Aryan Bakliwal <aryanbakliwal12345@gmail.com>
ec439d0
to
6a1a803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the tests to run since this looks like it'll do the trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging as needing changes since there's a bunch of test failures and also some linter issues:
cve_bin_tool/data_sources/nvd_source.py:426:13: F841 local variable 'e' is assigned to but never used
cve_bin_tool/data_sources/nvd_source.py:435:9: E303 too many blank lines (2)
fixes #3547
Added some code to catch exceptions when we can't connect to NVD, and fall back to the mirror.
Additionally, print a message rather than a traceback when mirror is also down.