feat: fourthwall update command #265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
force-pushed
the
feat/fw-update-command
branch
from
8e326f1 to
fc3d28a
Compare
bo0tzz
reviewed
Apr 24, 2025
src/services/discord.service.ts
Outdated
Comment on lines
475
to
482
| if (id) { | ||
| await this.updateOrder({ id, user, password }); | ||
| } | ||
|
|
||
| for await (const { id } of this.database.streamFourthwallOrders()) { | ||
| await this.updateOrder({ id, user, password }); | ||
| } |
There was a problem hiding this comment.
I think you need a return, or this'll always fall through :P
There was a problem hiding this comment.
:monakS: I swear that was there at some point lol
| @@ -207,6 +207,8 @@ export class WebhookService { | |||
| } | |||
| const dtoOrder = dto.type === 'ORDER_PLACED' ? dto.data : dto.data.order; | |||
|
|
|||
| await new Promise((resolve) => setTimeout(resolve, 10_000)); | |||
There was a problem hiding this comment.
I think this'll block the webhook which might make things unhappy? Idk if it's allowed in node but it might be better to send off a promise that does the whole write, and return on the webhook immediately.
There was a problem hiding this comment.
Oh that's a good call!
danieldietzler
force-pushed
the
feat/fw-update-command
branch
from
fc3d28a to
1fa39a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.