Skip to content

[DPO] Model forward pass padding side fix #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LeonEricsson
Copy link
Contributor

@LeonEricsson LeonEricsson commented Apr 16, 2025

Fixes #3306 by setting use_cache=False for the model forward pass allowing any padding side

This is an old issue that was fixed in #1290 but has been reintroduced, context (from #1290):

Setting use_cache=False circumvents all issues with FA-2 + DPO + Mistral/Qwen. In fact we should bypass that check since we are not in text generation mode when computing the loss function. use_cache is retrieved from the model config by default which falls back always to True. The cache is not used anyway when purely computing the logits so this change is fully BC

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@LeonEricsson LeonEricsson changed the title unset use_cache for model forward pass [DPO] Model forward pass padding side fix Apr 16, 2025
@LeonEricsson LeonEricsson marked this pull request as ready for review April 17, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SFT][DPO] Qwen2/2.5+FlashAttention2+Validation steps don't work
1 participant