Swift 6 compatible Hub package #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion/deserialization, Config compatible with jinja templating system
…ests/ConfigEquatable, Condig.Data equality improved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up for #189. It changes the remaining parts the the Hub package to be compatible with structured concurrency. As a result:
Downloader,LanguageModelConfigurationFromHubandHubApiconform to theSendableprotocol.Broadcaster<E: Sendable>got added as a building block replacingCurrentValueSubject.Package.swiftthat enable selective support for Swift 6 toHubandHubTestspackages.This PR can be merged after #189 becomes part of the mainline. In its current form, it's quite verbose. Relevant changes to this PR are located in
Source/Hub/Hub,Source/Hub/HubApi,Tests/HubTests/DownloaderTests.swiftandPackage.swift.