Update mpi_numpi.py #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the seed uses rank |
ocaisa
requested changes
Jan 7, 2022
| def inside_circle(total_count): | ||
|
|
||
| np.random.seed(2022*rank) |
There was a problem hiding this comment.
Aren't you now resetting the seed here every time the function is called? A rank specific seed is indeed necessary...perhaps this deserves an explanatory comment?
There was a problem hiding this comment.
The function is only called once. Would it be clearer if the seed is set once the rank has been determined, for example on line 9?
There was a problem hiding this comment.
I think that would be the right thing to do, there are two subtle things going on that should be clarified in a comment (or in the lesson?): you only set the seed once in your application, and the seed of each rank should be different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.