Skip to content

Miscellaneous Java codegen fixes #8581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Miscellaneous Java codegen fixes #8581

wants to merge 2 commits into from

Conversation

maxburke
Copy link
Contributor

@maxburke maxburke commented Apr 17, 2025 •
edited
Loading

Java code generation bug fixes:

  • internal vector class name clashes when schema includes a type named Vector
  • fields named notify clash with Java built-in notify method
  • fix clash between flatbuffer library Table type and schema types named Table
  • uint enums need to emit values as long constants

@github-actions github-actions bot added c++ codegen Involving generating code from schema java labels Apr 17, 2025
maxburke added 2 commits April 17, 2025 11:36
@maxburke
[java] bugfix: internal vector class name clashes when schema include…
c2b454f 
…s a type named Vector

[java] bugfix: fields named `notify` clash with Java built-in notify method

[java] bugfix: fix clash between flatbuffer library Table type and schema types named Table

[java] bugfix: uint enums need to emit values as long constants
@maxburke
Update generated test code with naming fixes
9baca1e
@maxburke maxburke force-pushed the java-naming-fixes branch from 049e485 to 9baca1e Compare April 17, 2025 18:36
@maxburke maxburke changed the title Java naming fixes Miscellaneous Java codegen fixes Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxburke