Undeploy an API without having to delete the Host #1532
Conversation
| @@ -182,4 +183,102 @@ impl ApiDeploymentApi { | |||
|
|
|||
| Ok(Json("API deployment deleted".to_string())) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is the endpoint. /:site/:id/:version
| @@ -457,10 +461,32 @@ impl<Namespace: GolemNamespace, AuthCtx: GolemAuthCtx> ApiDeploymentService<Auth | |||
| } | |||
|
|
|||
| if !remove_deployment_records.is_empty() { | |||
| // 3. Get the specific API definitions being undeployed | |||
There was a problem hiding this comment.
Removing component constraints during undeploy. There is no need for test as service_test already uses undeploy function
|
I side stepped the Issue #1529 by adding those parts manually back in. Did Cargo Make fix to check if everything is working. |
|
Please also add a test for the new endpoint to https://github.com/golemcloud/golem/tree/main/integration-tests/tests/api |
|
@mschuwalow All local deployment test always fail for me, and this has been the case for a while, since 2-3 week old HEAD. Failed tests:
- api::api_security::get_api_security_scheme (called `Result::unwrap()` on an `Err` value: not available on GRPC API: create_api_security_scheme)
- api::api_security::create_api_security_scheme (called `Result::unwrap()` on an `Err` value: not available on GRPC API: create_api_security_scheme)
- api::api_deployment::create_multiple_api_deployments_and_update_component_1 (called `Result::unwrap()` on an `Err` value: not available on GRPC API: create_api_deployment)
- api::api_deployment::create_multiple_api_deployments_and_update_component_2 (called `Result::unwrap()` on an `Err` value: not available on GRPC API: create_api_deployment)
- api::api_deployment::get_all_api_deployments (called `Result::unwrap()` on an `Err` value: not available on GRPC API: create_api_deployment)
- api::invocation_context::invocation_context_test (called `Result::unwrap()` on an `Err` value: not available on GRPC API: create_api_deployment)
�[2m2025-04-16T15:52:29.295200Z�[0m �[32m INFO�[0m �[2mgolem_test_framework::components�[0m�[2m:�[0m [componentsvc] �[2m2025-04-16T15:52:29.295101Z�[0m �[34mDEBUG�[0m �[2mtonic::transport::channel::service::connection�[0m�[2m:�[0m connection task error: hyper::Error(Io, Custom { kind: BrokenPipe, error: "connection closed because of a broken pipe" })
- api::api_deployment::create_api_deployment_and_update_component (called `Result::unwrap()` on an `Err` value: not available on GRPC API: create_api_deployment)
- api::api_deployment::create_and_get_api_deployment (called `Result::unwrap()` on an `Err` value: not available on GRPC API: create_api_deployment) |
|
Those tests need to be run in http mode which is currently controlled by an environment variable (this is not ideal but has its reasons). You can see the details of it in the makefile |
Nanashi-lab
force-pushed
the
single-delete
branch
from
f233a91 to
d174427
Compare
| @@ -1247,6 +1247,18 @@ pub trait WorkerService: WorkerServiceInternal { | |||
| } | |||
|
|
|||
| async fn kill(&self); | |||
|
|
|||
There was a problem hiding this comment.
added undeploy to test-framework
|
@mschuwalow This PR is ready for review, I am certain worker-tests-group4 timing out after 40 mins, is unrelated to this PR |
/closes #1494