Sidekiq 8.0 updates #2570
Draft
Sidekiq 8.0 updates #2570
+115
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
force-pushed
the
solnic/2569-sidekiq-800-beta
branch
from
2289251 to
0138b2d
Compare
solnic
force-pushed
the
solnic/2569-sidekiq-800-beta
branch
2 times, most recently
from
4da41ff to
6146494
Compare
solnic
force-pushed
the
solnic/2569-sidekiq-800-beta
branch
from
6146494 to
80ed68b
Compare
|
@sl0thentr0py we could get this one merged despite sidekiq-scheduler 6.0.0 being still in beta - WDYT? It's an optional dep and users can decide if they want to upgrade or not, and folks who don't use scheduler will be able to upgrade to sidekiq 8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Progress
Blocked by Sidekiq 8 compatability sidekiq-scheduler/sidekiq-scheduler#494 for now6.0.0.beta was releasedCloses #2569