Skip to content

ci: build sample apps on latest macOS image and Xcode version #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Apr 17, 2025

  • use macos-15 and Xcode 16.3 for sample app build jobs (they were a mixture of older ones, but this is just to make sure they compile at all, so we should be able to use the same thing for them all, and that should be what we're all presumably using on our local machines as well)
  • remove the default for the xcode version parameter in ci-select-xcode.sh: it's better to see exactly what version is being used in the workflow config files. if we were to change the default in the bash script, that change is invisible in the workflow configs. also, we didn't have any naked invocations anyways

make session-replay-camera-test-xcode will generate the project, although in the future we might want a small script to do this that can take some parameters like platform/version/language/UI-lib

#skip-changelog

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.791%. Comparing base (8a21e27) to head (8d1b1e7).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5105       +/-   ##
=============================================
+ Coverage   92.694%   92.791%   +0.096%     
=============================================
  Files          676       676               
  Lines        83874     83877        +3     
  Branches     29458     30530     +1072     
=============================================
+ Hits         77747     77831       +84     
+ Misses        6031      5949       -82     
- Partials        96        97        +1     

see 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a21e27...8d1b1e7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 17, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.66 ms 1240.51 ms 23.85 ms
Size 22.30 KiB 848.26 KiB 825.96 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f25febb 1238.80 ms 1245.35 ms 6.56 ms
69d8759 1235.71 ms 1241.34 ms 5.63 ms
ce4cfaf 1203.61 ms 1218.86 ms 15.25 ms
7419285 1209.53 ms 1244.72 ms 35.19 ms
b15521e 1224.44 ms 1251.13 ms 26.68 ms
bd2afa6 1245.24 ms 1263.18 ms 17.94 ms
53b29ac 1228.81 ms 1244.96 ms 16.15 ms
443fb02 1231.06 ms 1252.60 ms 21.54 ms
888a145 1228.63 ms 1248.94 ms 20.30 ms
70c49ca 1206.44 ms 1233.07 ms 26.62 ms

App size

Revision Plain With Sentry Diff
f25febb 21.58 KiB 414.92 KiB 393.34 KiB
69d8759 20.76 KiB 393.05 KiB 372.29 KiB
ce4cfaf 20.76 KiB 423.19 KiB 402.43 KiB
7419285 20.76 KiB 432.99 KiB 412.22 KiB
b15521e 21.58 KiB 573.18 KiB 551.60 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
53b29ac 22.32 KiB 819.55 KiB 797.24 KiB
443fb02 22.30 KiB 832.42 KiB 810.11 KiB
888a145 21.58 KiB 713.54 KiB 691.96 KiB
70c49ca 22.31 KiB 778.76 KiB 756.45 KiB

@armcknight armcknight changed the title ci: build sample apps on latest GA macOS image with modern Xcode ci: build sample apps on latest macOS image and Xcode version Apr 17, 2025
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
@armcknight armcknight merged commit d59dcc0 into main Apr 22, 2025
75 of 80 checks passed
@armcknight armcknight deleted the armcknight/ci/build-sample-apps-on-latest branch April 22, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants