-
-
Notifications
You must be signed in to change notification settings - Fork 346
ci: build sample apps on latest macOS image and Xcode version #5105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5105 +/- ##
=============================================
+ Coverage 92.694% 92.791% +0.096%
=============================================
Files 676 676
Lines 83874 83877 +3
Branches 29458 30530 +1072
=============================================
+ Hits 77747 77831 +84
+ Misses 6031 5949 -82
- Partials 96 97 +1 see 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f25febb | 1238.80 ms | 1245.35 ms | 6.56 ms |
69d8759 | 1235.71 ms | 1241.34 ms | 5.63 ms |
ce4cfaf | 1203.61 ms | 1218.86 ms | 15.25 ms |
7419285 | 1209.53 ms | 1244.72 ms | 35.19 ms |
b15521e | 1224.44 ms | 1251.13 ms | 26.68 ms |
bd2afa6 | 1245.24 ms | 1263.18 ms | 17.94 ms |
53b29ac | 1228.81 ms | 1244.96 ms | 16.15 ms |
443fb02 | 1231.06 ms | 1252.60 ms | 21.54 ms |
888a145 | 1228.63 ms | 1248.94 ms | 20.30 ms |
70c49ca | 1206.44 ms | 1233.07 ms | 26.62 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f25febb | 21.58 KiB | 414.92 KiB | 393.34 KiB |
69d8759 | 20.76 KiB | 393.05 KiB | 372.29 KiB |
ce4cfaf | 20.76 KiB | 423.19 KiB | 402.43 KiB |
7419285 | 20.76 KiB | 432.99 KiB | 412.22 KiB |
b15521e | 21.58 KiB | 573.18 KiB | 551.60 KiB |
bd2afa6 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
53b29ac | 22.32 KiB | 819.55 KiB | 797.24 KiB |
443fb02 | 22.30 KiB | 832.42 KiB | 810.11 KiB |
888a145 | 21.58 KiB | 713.54 KiB | 691.96 KiB |
70c49ca | 22.31 KiB | 778.76 KiB | 756.45 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
macos-15
and Xcode 16.3 for sample app build jobs (they were a mixture of older ones, but this is just to make sure they compile at all, so we should be able to use the same thing for them all, and that should be what we're all presumably using on our local machines as well)make session-replay-camera-test-xcode
will generate the project, although in the future we might want a small script to do this that can take some parameters like platform/version/language/UI-lib#skip-changelog