move GET /localization response object to schemas #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I informed the gematik TIM Team about this PR. They will add this topic to the agenda of the next TIM meeting with the TIM providers and manufacturers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating code from OpenApi spec files some generators cannot handle inline schemas properly. In this specific case the generator I use does not generate an enum as stated in the spec but simply a string. The content-type is defined as json, but generated client methods just return a string, where the Api returns a Json string, (
practvs."pract"), which makes it more difficult and error-prone to properly evaluate the Api response.Moving the enum to schemas avoids this issue. Please consider accepting this PR.
Kind regards,
Martin