Skip to content

tests: internal: fuzzers: split cmetrics decoding #10249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidKorczynski
Copy link
Contributor

This split is because prometheus has calls to abort

which forces prometheus decoding to cause exits. Consequently, coverage reports are missing for some of the cmetrics decoding files and the aborts also mean fuzzing of the other decoders will be limited.

Coverage report:
https://storage.googleapis.com/oss-fuzz-coverage/fluent-bit/reports/20250422/linux/src/fluent-bit/lib/cmetrics/src/report.html

This the above problems by splitting the decoding harness into two different fuzzers.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

This split is because prometheus has calls to abort
https://github.com/fluent/fluent-bit/blob/e8d608b7d7a7c12eae2dfce019f3c263257ed131/lib/cmetrics/src/cmt_decode_prometheus.y#L44
which forces prometheus decoding to cause exits. Consequently, coverage
reports are missing for some of the cmetrics decoding files and the
aborts also mean fuzzing of the other decoders will be limited.

Coverage report:
https://storage.googleapis.com/oss-fuzz-coverage/fluent-bit/reports/20250422/linux/src/fluent-bit/lib/cmetrics/src/report.html

This the above problems by splitting the decoding harness into two
different fuzzers.

Signed-off-by: David Korczynski <david@adalogics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant