Skip to content

Implementation of Cloud Storage function. #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Implementation of Cloud Storage function. #286

wants to merge 5 commits into from

Conversation

kiliczsh
Copy link

@kiliczsh kiliczsh commented Feb 24, 2021

Original PR: #72 #71
Configuration keys are missing on the actions machines so that had to handle exceptions.
Google was not allowing me to submit other users commits so that had to copy all, sorry @takuya1981.
@googlebot I consent.

All credits to @takuya1981 .

@hiranya911
Copy link
Contributor

Thanks @kiliczsh for the PR (complete with integration tests). Storage support in .NET has always been a bit of a conundrum. In all other languages of the Admin SDK, we expose the "bucket" as the primary abstraction. For example in Node.js:

const admin = require('firebase-admin');
admin.initializeApp({
  storageBucket: 'example.bucket.name',
});

const bucket = admin.storage().bucket();

But as you already know, in the .NET Storage client, that abstraction does not exist. This results in a very different developer experience. I'd like to run this by our internal API review team, and see what they think about it. Since we have no way of passing a bucket name to the Storage client via Firebase app options, I'm not certain if this integration adds a lot of value.

@kiliczsh kiliczsh closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants