Add babel plugin to @react-native/babel-preset for console.warn injection under deep react native imports
#50802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve imports
Summary:
The plugin analyses the source of all `import`, `require`, and `export` statements and injects the `console.warn` statement for each path targeting deep react-native source code. It runs only on a dev mode so there is no need to keep that in the `if (__DEV__) ` block. It is possible to disable this plugin by setting `disableDeepImportWarnings: true` and **resetting** the Metro cache:
```js
module.exports = {
presets: [['module:react-native/babel-preset', {
"disableDeepImportWarnings": true
}]],
};
```
Changelog:
[General][Internal] - Added plugin to react-native/babel-preset injecting `console.warn` for each react native deep import in dev mode.
For a given code:
```js
import { Image } from 'react-native';
import View from 'react-native/Libraries/Components/View/View';
const Text = require('react-native/Libraries/Text/Text');
export { PressabilityDebugView } from 'react-native/Libraries/Pressability/PressabilityDebug';
```
The transformed output should look like:
```js
import { Image } from 'react-native';
import View from 'react-native/Libraries/Components/View/View';
const Text = require('react-native/Libraries/Text/Text');
export { PressabilityDebugView } from 'react-native/Libraries/Pressability/PressabilityDebug';
console.warn("Deep imports from the 'react-native' package are deprecated ('react-native/Libraries/Components/View/View').");
console.warn("Deep imports from the 'react-native' package are deprecated ('react-native/Libraries/Text/Text').");
console.warn("Deep imports from the 'react-native' package are deprecated ('react-native/Libraries/Pressability/PressabilityDebug').");
```
For more information about why this plugin was needed, please check [RFC](react-native-community/discussions-and-proposals#894).
Reviewed By: huntie
Differential Revision: D70783145
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70783145 |
coado
changed the title
@react-native/babel-preset for console.warn injection under deep react native imports
coado
changed the title
@react-native/babel-preset for console.warn injection under deep react native imports@react-native/babel-preset for console.warn injection under deep react native imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The plugin analyses the source of all
import,require, andexportstatements and injects theconsole.warnstatement for each path targeting deep react-native source code. It runs only on a dev mode so there is no need to keep that in theif (__DEV__)block. It is possible to disable this plugin by settingdisableDeepImportWarnings: trueand resetting the Metro cache:Changelog:
[General][Internal] - Added plugin to react-native/babel-preset injecting
console.warnfor each react native deep import in dev mode.For a given code:
The transformed output should look like:
For more information about why this plugin was needed, please check RFC.
Reviewed By: huntie
Differential Revision: D70783145