refactor: migrate DynamicFromObject to Kotlin #50754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
19 tasks
mateoguzmana
requested changes
Apr 16, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
alanleedev
reviewed
Apr 17, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
alanleedev
reviewed
Apr 17, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
alanleedev
reviewed
Apr 17, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
alanleedev
reviewed
Apr 17, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
alanleedev
reviewed
Apr 17, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
alanleedev
reviewed
Apr 17, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
alanleedev
reviewed
Apr 17, 2025
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.kt
Outdated
Show resolved
Hide resolved
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @yasir6jan in 867858d When will my fix make it into a release? | How to file a pick request? |
|
@alanleedev merged this pull request in 867858d. |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: PR migrates DynamicFromObject class to Kotlin as part of facebook#50513 work. ## Changelog: [ANDROID] [CHANGED] - Migrated DynamicFromObject to Kotlin Pull Request resolved: facebook#50754 Test Plan: Run RN-Tester application and played around with it a bit. Reviewed By: mlord93 Differential Revision: D73118014 Pulled By: alanleedev fbshipit-source-id: 84958ff07ccafea9ec3dbdf06467c638eb92d49d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PR migrates DynamicFromObject class to Kotlin as part of #50513 work.
Changelog:
[ANDROID] [CHANGED] - Migrated DynamicFromObject to Kotlin
Test Plan:
Run RN-Tester application and played around with it a bit.