Skip to content

[test] Create CE version of node burn test #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

teojgo
Copy link
Collaborator

@teojgo teojgo commented Apr 8, 2025

No description provided.

Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
@teojgo teojgo requested review from jgphpc and ekouts April 8, 2025 14:31
@teojgo teojgo self-assigned this Apr 8, 2025
Copy link
Collaborator

@jgphpc jgphpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>

class NodeBurnCE(rfm.RunOnlyRegressionTest, ContainerEngineMixin):
valid_prog_environs = ['builtin']
nb_duration = variable(int, value=20)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can set the appropriate timelimit in the job when the duration is longer than 10 minutes. What do you think? We could also set it from the cli, but since we have this information before running maybe it's better

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is seconds actually but it's a good idea.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how I could get the time_limit? Because I think it is injected during the batch script creation if not set explicitly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm in which case? You want to know what is the default of the partition or in case someone over-writes it from the cli?

Theofilos Manitaras added 6 commits April 11, 2025 16:02
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants