-
Notifications
You must be signed in to change notification settings - Fork 26
[test] Create CE version of node burn test #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
|
||
class NodeBurnCE(rfm.RunOnlyRegressionTest, ContainerEngineMixin): | ||
valid_prog_environs = ['builtin'] | ||
nb_duration = variable(int, value=20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can set the appropriate timelimit in the job when the duration is longer than 10 minutes. What do you think? We could also set it from the cli, but since we have this information before running maybe it's better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is seconds actually but it's a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know how I could get the time_limit
? Because I think it is injected during the batch script creation if not set explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm in which case? You want to know what is the default of the partition or in case someone over-writes it from the cli?
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
Signed-off-by: Theofilos Manitaras <manitart@cscs.ch>
No description provided.