-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update waveshare_epaper.rst to add 7.50in-bwr #4818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
Update waveshare_epaper.rst to add 7.50in-bwr. Will immediately follow PR on the esphome repository.
WalkthroughA new configuration entry has been added to the Waveshare E-Paper display documentation. This entry introduces the Changes
Sequence Diagram(s)Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/display/waveshare_epaper.rst (1)
133-140
: Consider a Cross-reference Reminder.
Once the related pull request in the esphome repository is finalized, please ensure that the newly added model is also referenced in the/components/index.rst
file as mentioned in the checklist. This will help maintain consistency across the documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/display/waveshare_epaper.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams
**
: - Do not generate or add any sequence diagrams
components/display/waveshare_epaper.rst
🔇 Additional comments (1)
components/display/waveshare_epaper.rst (1)
135-135
: New Model Entry Added Correctly.
The new bullet point for7.50in-bwr
is formatted and described consistently with the other model options. The description clearly indicates that this variant enables BWR rendering and uses double the RAM compared to B/W rendering, which aligns with the intended update.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Update waveshare_epaper.rst to add 7.50in-bwr. Will immediately follow PR on the esphome repository.
Description:
Related issue (if applicable): fixes
(no issue)
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rst
when creating new documents for new components or cookbook.