Add support for -fcoverage-mapping support #24160
Conversation
This is enought make it work up until llvm-cov tries to read the named data sections in the binary and can't find them. For this final part to work we probably need to switch the object format to using multiple code and data sections: WebAssembly/tool-conventions#138 Not sure if its worth submitting this part in isolation without a fully working solution? See emscripten-core#13046
# Conflicts: # emcc.py # tests/test_core.py # tools/shared.py # tools/system_libs.py
| @@ -23,6 +23,7 @@ | |||
| ('lib', 'lsan'), | |||
| ('lib', 'ubsan'), | |||
| ('lib', 'ubsan_minimal'), | |||
| ('lib', 'profile'), | |||
There was a problem hiding this comment.
Can you make sure you copy these files from compiler-rt at the same revision as the existing file?
Based on system/lib/compiler-rt/readme.txt it looks like they should be copied from https://github.com/llvm/llvm-project/compare/llvmorg-19.1.6
There was a problem hiding this comment.
@sbc100 I was under the impression i need to sync with https://github.com/emscripten-core/llvm-project/tree/main/compiler-rt/lib/profile
Version 19 will not work, as this requires llvm/llvm-project#111332 + a few more commits. Basically we need compiler-rt profile 20+
There was a problem hiding this comment.
What is required or triggers a creation of emscripten-lib-20 branch? We will need both compiler-rt source based on 20+ along with version 20+ of llvm-profdata and llvm-cov for the tests
There was a problem hiding this comment.
This is rather complex process that we have to perform each time a new LLVM release is made. I opened #24182 to get it done.
arsnyder16
force-pushed
the
arsnyder16-fcoverage
branch
from
f1a383d to
10bbd61
Compare
| @@ -23,6 +23,7 @@ | |||
| ('lib', 'lsan'), | |||
| ('lib', 'ubsan'), | |||
| ('lib', 'ubsan_minimal'), | |||
| ('lib', 'profile'), | |||
There was a problem hiding this comment.
@sbc100 I was under the impression i need to sync with https://github.com/emscripten-core/llvm-project/tree/main/compiler-rt/lib/profile
Version 19 will not work, as this requires llvm/llvm-project#111332 + a few more commits. Basically we need compiler-rt profile 20+
| @@ -754,6 +754,8 @@ class OFormat(Enum): | |||
| LLVM_OBJCOPY = os.path.expanduser(build_llvm_tool_path(exe_suffix('llvm-objcopy'))) | |||
| LLVM_STRIP = os.path.expanduser(build_llvm_tool_path(exe_suffix('llvm-strip'))) | |||
| WASM_LD = os.path.expanduser(build_llvm_tool_path(exe_suffix('wasm-ld'))) | |||
| LLVM_PROFDATA = 'llvm-profdata-20'#os.path.expanduser(build_llvm_tool_path(exe_suffix('llvm-profdata'))) | |||
| LLVM_COV = 'llvm-cov-20'#os.path.expanduser(build_llvm_tool_path(exe_suffix('llvm-cov'))) | |||
There was a problem hiding this comment.
how do we get these included?
Main introduction is porting
llvm-project/compiler_rt/lib/profileinto system/lib/compiler_rt/lib/profileRelated
#13072
llvm/llvm-project#111332
No modifications were required for what was ported. llvm-cov worked fine for me with simple project.
-gis required to produce a properly instrumented binaryerror: failed to load coverage: 'my.wasm': no coverage data found