Develop #3
Merged
Develop #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betzrhodes
commented
Aug 24, 2017
betzrhodes
commented
- Fix for Issue Develop #3
- Updated docs to address Issue updated Modbus485 to ModbusSerial #4 & Add Device Address #6
- Fixed typos from MP pull request
- Updated library names to match library standards
- Added license and updated all files with license and license links
- Incremented version number
Docs updated
A new test case was written for it 2. Added notes to advise users of the TCP connection dropout after a certain amount of idle time 3. Added notes to inform users that the order of operation in readWriteMultipleRegisters may differ from the modus spec in reality .
# Conflicts: # ModbusTCPMaster/README.md
p;arsing error fix from mysticpants develop branch
|
Clean up for v1.0.1 library release. |
ppetrosh
approved these changes
Aug 24, 2017
|
Do we want to bump the libraries to 2.0.0 since the new names mean users have to change their code? |
|
They only have to change the require statement - which they have to change when we update a version number. There are no other code changes required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.