Skip to content

fix(transaction): Fix schedule queues #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dranikpg
Copy link
Contributor

@dranikpg dranikpg commented Apr 12, 2025

If it reproduces locally on x86, it must be something simple. My only explanation is that we spuriously reorder the next read in sq.queue.Pop() before we update armed, so:

  • T0: reads from an empty queue
  • T1: stores the next context in the queue
  • T1: makes sure armed is still true
  • T0: clears armed flag and proceeds with stale data from (0)

@dranikpg dranikpg force-pushed the dranikpg-fix-tx-scheq branch from 7e112d1 to d062db6 Compare April 12, 2025 07:26
@dranikpg dranikpg marked this pull request as ready for review April 12, 2025 08:35
@dranikpg
Copy link
Contributor Author

But I still don't like schedule chains 😄 For one, they're overcomplicated, the armed flag & and a full blown mpsc queue is obsolete. For a second, it's only a partial implementation/fix

@romange
Copy link
Collaborator

romange commented Apr 12, 2025

I agree that their added value is questionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants