Skip to content

[Testing] Feature Matrix UITest Cases for CollectionView Grouping Feature #29002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NafeelaNazhir
Copy link
Contributor

This PR includes a comprehensive set of UI test cases for the CollectionView control. The tests validate the Grouping feature functionality in CollectionView, including properties such as: IsGrouped, CanMixGroups, CanReorderItems, GroupHeaderTemplate, GroupFooterTemplate,Header, Footer, ItemsLayout, ItemTemplate, ItemsSource.

New Features :

  • Added CollectionViewFeaturePage and CollectionViewControlPage to showcase the CollectionView grouping feature. (src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewFeaturePage.xaml [1] src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewControlPage.xaml [2]
  • Implemented the CollectionViewViewModel to manage the data and behavior of the CollectionView, including support for grouped items, reordering, and custom templates. (src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewViewModel.cs src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewViewModel.csR1-R292)

Code Enhancements:

Issues Identified in Grouping Feature

@dotnet-policy-service dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Apr 15, 2025
@NafeelaNazhir NafeelaNazhir added area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration and removed community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Apr 15, 2025
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NafeelaNazhir NafeelaNazhir force-pushed the nafeela-CollectionView branch from 7da2edb to 3ce5e5a Compare April 16, 2025 09:58
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NafeelaNazhir NafeelaNazhir marked this pull request as ready for review April 22, 2025 10:09
@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 10:09
@NafeelaNazhir NafeelaNazhir requested a review from a team as a code owner April 22, 2025 10:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive UI test cases and feature pages to validate the CollectionView grouping functionality while refactoring some legacy pages.

  • Added new pages (CollectionViewFeaturePage, CollectionViewGroupingPage, etc.) and a corresponding view model (CollectionViewViewModel) with additional properties for grouping.
  • Updated CorePageView to reference the new CollectionView feature page and removed obsolete pages.

Reviewed Changes

Copilot reviewed 12 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
HeaderFooterMainPage.xaml.cs Removed outdated header/footer page.
HeaderFooterOptionsPage.xaml.cs Updated to support dynamic header/footer options for CollectionView grouping.
CollectionViewHeaderPage.xaml.cs Introduced to showcase header configurations.
CollectionViewViewModel.cs Extended to support new properties (CanReorderItems, CanMixGroups) and a new ItemsSourceType value.
GroupingOptionsPage.xaml.cs Added to manage options for grouped CollectionView.
CollectionViewGroupingPage.xaml.cs Added to test grouping functionality.
CollectionViewFeaturePage.xaml.cs Added as an entry point for the CollectionView feature matrix.
CollectionViewControlPage.xaml.cs Removed in favor of the consolidated feature pages.
CorePageView.cs Updated GalleryPageFactory to reference the new CollectionView feature page.
Files not reviewed (6)
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewFeaturePage.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewGroupingPage.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/GroupingOptionsPage.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/HeaderFooter/CollectionViewHeaderPage.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/HeaderFooter/HeaderFooterOptionsPage.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/HeaderFooterMainPage.xaml: Language not supported
Comments suppressed due to low confidence (2)

src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewViewModel.cs:188

  • Ensure that test cases are added for the new properties 'CanReorderItems' and 'CanMixGroups' in both TestCases.HostApp and TestCases.Shared.Tests.
public bool CanReorderItems

src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewViewModel.cs:218

  • [nitpick] Consider clarifying the naming of the enum value 'ObservableCollectionT' so that it clearly differentiates from 'ObservableCollection25T' and 'ObservableCollection5T'.
ItemsSourceType.ObservableCollectionT => _observableCollection,

jsuarezruiz
jsuarezruiz previously approved these changes Apr 23, 2025
@NafeelaNazhir NafeelaNazhir force-pushed the nafeela-CollectionView branch from bc5b786 to 16fa275 Compare April 24, 2025 04:59
@PureWeen PureWeen changed the base branch from main to inflight/candidate April 24, 2025 16:29
@PureWeen PureWeen changed the base branch from inflight/candidate to main April 24, 2025 16:29
@PureWeen PureWeen changed the base branch from main to inflight/candidate April 24, 2025 16:30
@PureWeen PureWeen merged commit 0927ff2 into dotnet:inflight/candidate Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants