asgiref.sync trio support #509
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
trio-support-in-sync
branch
from
838227e to
152d990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just a sketch, I've not even tested it on trio yet - just a demo to see approximately how much code needs to change. Ok I needed to try it out so I ported the relevant parts of the suite to anyioThe design I've gone with is to make as few changes to the asyncio "trio not installed" code path as possible, rather than say using anyio and refactoring everything to use a trionic style. I want this to be as minimal and nonintrusive on existing asyncio use cases.
What needs doing is duplicating the test suite withDone!pytest-trio(or using anyio's pytest plugin for both) and fixing the mypy errors.To fix the mypy errors I'll probably want to move the trio versions of the all the util functions into their own private moduleDone!