Skip to content

rename /map to /map.html #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

rename /map to /map.html #1136

merged 2 commits into from
Apr 24, 2025

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago requested review from j08lue and hrodmn April 23, 2025 11:59
j08lue
j08lue requested changes Apr 23, 2025
View reviewed changes
Copy link
Member

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are renaming this anyways (breaking change), would it perhaps be better to choose a less similar name to /map and perhaps even more descriptive?

Something like /preview.html or /viewer.html or so?

@vincentsarago
Copy link
Member Author

@j08lue why not.

we already have /preview so preview.html will be confusing. There is already a /viewer which is provided by the VIewerExtension (return a much more complexe HTML viewer).

@j08lue
Copy link
Member

j08lue commented Apr 24, 2025 •
edited
Loading

we already have [/preview and /viewer]

Right, I forgot about that. Well, I do not have any other ideas, so ¯\_(ツ)_/¯

@vincentsarago vincentsarago merged commit f125436 into main Apr 24, 2025
10 checks passed
@vincentsarago vincentsarago deleted the feature/rename-map-endpoint branch April 24, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j08lue j08lue j08lue approved these changes

@hrodmn hrodmn hrodmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentsarago @j08lue @hrodmn