Skip to content

chore: improve lint:docs script #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 26, 2025

Now, assertions use assert() instead of manually pushing to diagnostics.

Step towards having this be a tool that other codebases can use.

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (f8894da) to head (cf0988b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6625   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         583      583           
  Lines       46478    46478           
  Branches     6523     6523           
=======================================
+ Hits        44036    44037    +1     
+ Misses       2399     2398    -1     
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iuioiua iuioiua marked this pull request as ready for review April 27, 2025 05:25
@iuioiua iuioiua requested a review from kt3k as a code owner April 27, 2025 05:25
@kt3k
Copy link
Member

kt3k commented Apr 28, 2025

Other part looks good to me

@iuioiua iuioiua requested a review from kt3k April 28, 2025 05:39
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 096f0be into denoland:main Apr 28, 2025
18 checks passed
@iuioiua iuioiua deleted the check-docs-assert branch April 28, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants