Skip to content

BREAKING(fs,dotenv): drop Deno v1.x support #6624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 25, 2025

This PR drops Deno v1.x from being used in CI, or rather it just removes the guarantee that the Standard Library will work with Deno v1.x (even though it does 99% of the time). I think this is reasonable to do now as Deno 2 is LTS.

The title is accurate but may seem more significant than these changes are. This just changes the expected error when insufficient permissions are granted for some operations in @std/fs and @std/dotenv. See Deno.errors.NotCapable.

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (f8894da) to head (ebdb7eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6624      +/-   ##
==========================================
- Coverage   94.74%   94.17%   -0.57%     
==========================================
  Files         583      580       -3     
  Lines       46478    41419    -5059     
  Branches     6523     6511      -12     
==========================================
- Hits        44036    39008    -5028     
+ Misses       2399     2362      -37     
- Partials       43       49       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iuioiua iuioiua marked this pull request as ready for review April 25, 2025 23:52
@iuioiua iuioiua requested a review from kt3k as a code owner April 25, 2025 23:52
@kt3k
Copy link
Member

kt3k commented Apr 26, 2025

v1 is still significantly used according to our internal check. (Probably many users are still stuck with v1 because of CLI's breaking changes)

Screenshot 2025-04-26 at 22 06 17

I don't think we are ready to do this change.

cc @bartlomieju @ry

@@ -19,7 +19,6 @@ jobs:
fail-fast: false
matrix:
deno:
- v1.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we drop v1 CI, we don't what packages work in v1 anymore (any package could randomly break in v1 in the future development)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants