Skip to content

refactor(toml): remove Scanner test #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

These test cases are covered by other tests.

@timreichen timreichen requested a review from kt3k as a code owner April 15, 2025 12:13
@github-actions github-actions bot added the toml label Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (645875e) to head (2aefbfb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6584   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         580      580           
  Lines       43772    43772           
  Branches     6480     6480           
=======================================
  Hits        41384    41384           
  Misses       2345     2345           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented Apr 17, 2025

They look good for demonstrating what Scanner does as test cases. I'm not in favor of removing them

See also https://www.thecoder.cafe/p/unit-tests-as-documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants