Skip to content

refactor(toml): rewrite deepAssignWithTable #6580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

This PR splits deepAssignWithTable() into deepAssignTable() and deepAssignTableArray() and BlockParseResultBody into Block, Table, TableArray types.
This improves the readability and allows for a reduction in toml().
This PR also fixes a type bug where the or() parser combinator only allowed the same generic for parsers.

@timreichen timreichen requested a review from kt3k as a code owner April 15, 2025 10:20
@github-actions github-actions bot added the toml label Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.53%. Comparing base (2a059d9) to head (8950cf8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6580      +/-   ##
==========================================
- Coverage   94.54%   94.53%   -0.01%     
==========================================
  Files         580      580              
  Lines       43891    43897       +6     
  Branches     6501     6504       +3     
==========================================
+ Hits        41496    41499       +3     
- Misses       2352     2355       +3     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant