Skip to content

creating a new file for sorting #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

creating a new file for sorting #2

wants to merge 1 commit into from

Conversation

radhikasethi2011
Copy link

All sorting algorithms can be a part of this folder.

All sorting algorithms can be a part of this folder.
@radhikasethi2011
Copy link
Author

Please accept the new commit to master.
I can then start contributing to the "sorting" folder

@darpanjbora
Copy link
Owner

Please accept the new commit to master.
I can then start contributing to the "sorting" folder

Hi, @radhikasethi2011.

Please contribute some algorithms for your PR to get approved. Only creating a folder won't be counted as a valid PR. Thanks.

@radhikasethi2011
Copy link
Author

How do i add files into this folder then? i can't find it, that's why

@darpanjbora
Copy link
Owner

How do i add files into this folder then? i can't find it, that's why

Fork the repo. Clone it into your local. Add the new folder 'sorting' in the base folder. Create new files within the folder. Once done, create a PR.

@darpanjbora darpanjbora added the invalid This doesn't seem right label Oct 13, 2019
@radhikasethi2011
Copy link
Author

Okay, i'm working on it!

@darpanjbora
Copy link
Owner

Okay, i'm working on it!

MergeSort is already added. Please fetch the code with the latest commits.

@radhikasethi2011
Copy link
Author

I'm new to github. can you let me know if BubbleSort is added too? Can I make a PR for that

@radhikasethi2011
Copy link
Author

I was working on sorting, but i see, you've already added a new folder for sorting. With all kinds of sorts.
This folder didn't exist before, tho.

@darpanjbora
Copy link
Owner

Yes, it is added too. You can check the already added sorting algorithms here. You can contribute by adding any other algorithm (Not necessarily to be a sorting algorithm).

And yes, sorting folder wasn't there initially. But people contributed and added sorting algorithms already. That's why I asked you to fetch the code with the latest commits. Since multiple PRs have been merged already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants