Fix: Remove stop parameter for o4-mini model #2663
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stop parameter not supported with o4-mini model
Description
This PR fixes issue #2661 where attempting to use the
o4-mini
model raises an exception because the OpenAI API returns an error indicating that thestop
parameter is not supported for this model.The fix modifies the
_prepare_completion_params
method in theLLM
class to check if the model is "o4-mini" and remove the "stop" parameter before making API calls.Changes
_prepare_completion_params
to remove the "stop" parameter when using "o4-mini" modelTesting
Fixes #2661
Link to Devin run: https://app.devin.ai/sessions/1756ea2405544d65a3ecd6a27bf25311
Requested by: Joe Moura (joao@crewai.com)